Fix: Fixed performance issue with SMB shares #16812
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KFlab <[email protected]>
Signed-off-by: KFlab <[email protected]>
Signed-off-by: KFlab <[email protected]>
Signed-off-by: KFlab <[email protected]>
Signed-off-by: KFlab <[email protected]>
yaira2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Related to #12704
I'm not pro in c_sh,
This is only a temporary solution.
Because my work relies heavily on various mapped network drives,
Till now, this patch work for me.
Steps used to test these changes
1） Enter an smb that has been mapped as a network drive like "Y:\Download"
2）enter the directory containing a large number of large compressed files and wait for them to be lod.
3) Observe whether the loading speed is the same with "\192.168.0.1\nfs\Download"
ps:
The root cause may be the reading of the zip file，
Although it has not been tested, this is just a guess. Will huge files on slow devices have similar phenomena?
I also think that the compressed file recognition problem I mentioned in #12704 may aggravate this phenomenon.
Additionally, I would suggest that the file system type detection could be more unified into one function, rather than being everywhere.